commit 6777a4a12ced35a54102404059802cdd738365aa Author: Matthew Barnes Date: Sat Nov 17 08:31:49 2012 -0500 NEWS update for 3.7.2 release. NEWS | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) commit 32f956eb9f77ac1794b47fa2bf09e1e1d1186be1 Author: Matthew Barnes Date: Sat Nov 17 08:33:51 2012 -0500 Missed a couple files when removing EBookBackendVCF. configure.ac | 1 - po/POTFILES.in | 1 - 2 files changed, 2 deletions(-) commit 55e8a6170b6c294e1a9c3c4d6b446caf3fd4818f Author: Matthew Barnes Date: Sat Nov 17 07:54:37 2012 -0500 Remove EBookBackendVCF. Strolling through the commit history of this backend, I had to dig all the way back to 2005 before I started seeing actual development work. Since then the commits have all been code cleanups and adapting it to backend API changes. There is no way to create a VCF address book from Evolution, which means this entire backend is dead code and we've been wasting our time with it. Dump it. addressbook/backends/Makefile.am | 2 +- addressbook/backends/vcf/Makefile.am | 35 - .../backends/vcf/e-book-backend-vcf-factory.c | 76 -- addressbook/backends/vcf/e-book-backend-vcf.c | 787 -------------------- addressbook/backends/vcf/e-book-backend-vcf.h | 68 -- addressbook/backends/vcf/e-source-vcf.c | 185 ----- addressbook/backends/vcf/e-source-vcf.h | 69 -- 7 files changed, 1 insertion(+), 1221 deletions(-) commit 1e21ca420a5e0d17899451438a86692c271f5ca6 Author: Matthew Barnes Date: Fri Nov 16 14:16:45 2012 -0500 Deprecate BOOK_BACKEND_PROPERTY_SUPPORTED_AUTH_METHODS. This property is not used anywhere. Remove all references to it from built-in backends. The following EBook functions now simply return an empty list: e_book_get_supported_auth_methods e_book_async_get_supported_auth_methods e_book_get_supported_auth_methods_async addressbook/backends/file/e-book-backend-file.c | 2 - .../backends/google/e-book-backend-google.c | 2 - addressbook/backends/ldap/e-book-backend-ldap.c | 36 ------ addressbook/backends/vcf/e-book-backend-vcf.c | 2 - .../backends/webdav/e-book-backend-webdav.c | 2 - addressbook/libebook/e-book-client.c | 4 - addressbook/libebook/e-book-client.h | 20 ++-- addressbook/libebook/e-book.c | 125 +++----------------- addressbook/libedata-book/e-book-backend.h | 18 +-- .../addressbook/libebook/libebook-sections.txt | 2 +- .../libedata-book/libedata-book-sections.txt | 2 +- libedataserverui/e-client-utils.c | 1 - tests/libebook/client/test-client-examine.c | 4 +- 13 files changed, 39 insertions(+), 181 deletions(-) commit 41c0d9d4926135a67ff63d56126801de67a51cd6 Author: Milan Crha Date: Fri Nov 16 09:59:51 2012 +0100 Bug #674454 - Crash in e_book_backend_ldap_authenticate_user() addressbook/backends/ldap/e-book-backend-ldap.c | 3 +++ 1 file changed, 3 insertions(+) commit 5cac1ca5b92827e27de536580e0b80f609ae4370 Author: Milan Crha Date: Wed Nov 14 23:37:24 2012 +0100 Replace deprecated Gtk+ symbols (as of Gtk+ 3.6.x) configure.ac | 7 +- libedataserverui/e-categories-editor.c | 58 ++-- libedataserverui/e-categories-editor.h | 4 +- libedataserverui/e-category-editor.c | 48 ++-- libedataserverui/e-cell-renderer-color.c | 8 +- libedataserverui/e-name-selector-dialog.c | 318 ++++++++++++--------- libedataserverui/e-name-selector-list.c | 108 +++++-- libedataserverui/e-passwords-win32.c | 60 ++-- libedataserverui/e-passwords.c | 58 ++-- libedataserverui/e-source-selector-dialog.c | 30 +- tests/libedataserverui/test-category-completion.c | 15 +- tests/libedataserverui/test-contact-store.c | 19 +- tests/libedataserverui/test-source-selector.c | 22 +- 13 files changed, 462 insertions(+), 293 deletions(-) commit 2dbc5291a72a2454c3d27fbdf7a13dca73fd3370 Author: Milan Crha Date: Tue Nov 13 16:58:49 2012 +0100 Bug #688146 - Crash in Contacts calendar backend .../backends/contacts/e-cal-backend-contacts.c | 108 ++++++++++++-------- 1 file changed, 65 insertions(+), 43 deletions(-) commit ea2d527517e9ae727b2ec1ba729d8e4dfe656fe4 Author: Paul Menzel Date: Tue Nov 13 14:02:38 2012 +0100 Bug #687634 - Improve camel console warning text camel/camel-mime-filter-tohtml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ab063796ca9c8dba966fc96d0e4d3cad295495c Author: Milan Crha Date: Tue Nov 13 08:37:40 2012 +0100 Bug #687865 - Shows old reminders for GOA accounts modules/google-backend/module-google-backend.c | 12 ++++++++++++ modules/yahoo-backend/module-yahoo-backend.c | 12 ++++++++++++ 2 files changed, 24 insertions(+) commit 3b27a024da8fefc767db4bfb2f043fdfa179a98b Author: Matthew Barnes Date: Mon Nov 12 19:17:29 2012 -0500 Revert "EBookBackendGoogle: Make room for other authorizers." This reverts commit a5dae1a780f898ab453f574440ca02e108b4ebef. Actually no, don't want to do that. Misread the code. .../backends/google/e-book-backend-google.c | 26 ++++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) commit a5dae1a780f898ab453f574440ca02e108b4ebef Author: Matthew Barnes Date: Mon Nov 12 18:56:10 2012 -0500 EBookBackendGoogle: Make room for other authorizers. .../backends/google/e-book-backend-google.c | 26 ++++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) commit 39211c843b5e1ec550a67ca30e082034e706a920 Author: Christian Kirbach Date: Mon Nov 12 22:49:34 2012 +0100 Update German translation po/de.po | 1112 ++++++++++++++++++++++++++++---------------------------------- 1 file changed, 507 insertions(+), 605 deletions(-) commit 503211fdf130cf9954f2d3a98608c550f0975828 Author: Matthew Barnes Date: Mon Nov 12 11:44:11 2012 -0500 EDataBookFactory: Remove the GOA-specific bits. Defer to the gnome-online-accounts module. See the previous commit. addressbook/libedata-book/Makefile.am | 2 - addressbook/libedata-book/e-data-book-factory.c | 172 ----------------------- 2 files changed, 174 deletions(-) commit 4b0ccdb2148f3a9b0dfd362fc91cef9fcd6b4d51 Author: Matthew Barnes Date: Mon Nov 12 11:38:45 2012 -0500 gnome-online-accounts: Add an EDataFactory extension. This extension takes over for the GOA bits in EDataBookFactory. Install this extension to both the addressbook and calendar backend directories, even though only EBookBackendGoogle uses it at present. modules/gnome-online-accounts/Makefile.am | 45 +++ .../module-data-factory-goa.c | 295 ++++++++++++++++++++ 2 files changed, 340 insertions(+) commit 9c4d563646efa3d447545213bfa6ba808410f119 Author: Matthew Barnes Date: Mon Nov 12 09:31:16 2012 -0500 EDataFactory: Add a "backend-created" signal. Allows EDataFactory extensions to catch newly-created backends and perform additional initialization on it. The use case I have in mind is to move all the GOA initialization in EDataBookFactory to the gnome-online-accounts module as an extension. Note this uses one of the reserved pointer slots in EDataFactoryClass and therefore does not break ABI. libebackend/e-data-factory.c | 32 ++++++++++++++++++++++++++++++++ libebackend/e-data-factory.h | 6 +++++- 2 files changed, 37 insertions(+), 1 deletion(-) commit 88286373727ef57c2b20b107467db65fd882b0f3 Author: Matthew Barnes Date: Mon Nov 12 06:54:26 2012 -0500 Remove unused OAUTH_CFLAGS / OAUTH_LIBS. Missed these when I removed the liboauth dependency. addressbook/backends/google/Makefile.am | 2 -- 1 file changed, 2 deletions(-) commit 35122bd5e66db1788b5bc6973e7dfcb27c7dbc09 Author: Matthew Barnes Date: Fri Nov 9 21:54:46 2012 -0500 Coding style and whitespace cleanup. .../file/e-book-backend-file-migrate-bdb.c | 29 ++--- .../file/e-book-backend-file-migrate-bdb.h | 4 - addressbook/backends/file/e-book-backend-file.c | 136 +++++++++++--------- addressbook/backends/google/e-book-google-utils.c | 52 ++++---- .../backends/contacts/e-cal-backend-contacts.c | 3 +- camel/camel-certdb.c | 9 +- camel/camel-imapx-server.c | 6 +- camel/camel-mime-utils.c | 2 +- camel/providers/pop3/camel-pop3-engine.c | 8 +- camel/providers/pop3/camel-pop3-folder.c | 8 +- libebackend/e-authentication-mediator.c | 3 +- libebackend/e-collection-backend.c | 9 +- libedataserver/e-source-registry.c | 3 +- modules/gnome-online-accounts/goaewsclient.c | 6 +- .../module-gnome-online-accounts.c | 9 +- 15 files changed, 148 insertions(+), 139 deletions(-) commit b84e7982ebf2055bc4a2fa13ba99265e0db68c62 Author: Piotr Drąg Date: Sat Nov 10 00:29:49 2012 +0100 Updated POTFILES.in po/POTFILES.in | 1 + 1 file changed, 1 insertion(+) commit 52a563098cce94dd12b417a19a458dac7b35db4a Author: Matthew Barnes Date: Fri Nov 9 11:25:13 2012 -0500 EBookBackendSqliteDB cleanups. Improve error handling and make commits/rollbacks less awkward. .../libedata-book/e-book-backend-sqlitedb.c | 981 ++++++++++++-------- .../libedata-book/e-book-backend-sqlitedb.h | 271 +++--- 2 files changed, 708 insertions(+), 544 deletions(-) commit f28dd62c5ec41791227cc0e8293f5c205332779a Author: Matthew Barnes Date: Fri Nov 9 07:49:33 2012 -0500 Use g_type_ensure() where applicable. libedataserver/e-source-registry.c | 8 +----- libedataserver/e-source.c | 53 ++++++++++++++++-------------------- 2 files changed, 25 insertions(+), 36 deletions(-) commit e306c4508b277492c8ddf4e6abf4ba13f6f31215 Author: Matthew Barnes Date: Fri Nov 9 06:29:21 2012 -0500 CamelIMAPXServer: Work around crash in imapx_exit_idle(). g_cond_clear() doesn't like being given an uninitialized GCond. The "start_watch_cond" and "start_watch_exit" structures are being cleared unconditionally, so we should initialize them unconditionally. camel/camel-imapx-server.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 047d510948b382568527298ae465264aa27b5db6 Author: Matej Urbančič Date: Thu Nov 8 21:36:46 2012 +0100 Updated Slovenian translation po/sl.po | 315 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 160 insertions(+), 155 deletions(-) commit 30dcfe4d336c86f29bd66ff11c2eaf18a318a728 Author: Matthew Barnes Date: Thu Nov 8 08:30:22 2012 -0500 Restore e_flag_timed_wait(). Just deprecate the function, don't delete it. GTimeVal isn't going away any time soon. It's not worth a libedataserver soname bump. configure.ac | 2 +- .../libedataserver/libedataserver-sections.txt | 3 +- libedataserver/e-flag.c | 38 ++++++++++++++++++++ libedataserver/e-flag.h | 5 +++ 4 files changed, 46 insertions(+), 2 deletions(-) commit 04065f256476ffd9d54c62e66cb60d04b770e92a Author: Tristan Van Berkom Date: Thu Nov 8 20:28:06 2012 +0900 Disabled debug print in EBookBackendFile This was somehow missed in my last commit. addressbook/backends/file/e-book-backend-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b66eb3c83d59bc44159bfa00e470bee5c767c07d Author: Tristan Van Berkom Date: Mon Oct 29 15:33:09 2012 +0900 Local file backend modified to use sqlite db exclusively Patch includes a migration routine to migrate data from a previously installed BDB. addressbook/backends/file/Makefile.am | 2 + .../file/e-book-backend-file-migrate-bdb.c | 528 ++++++++ .../file/e-book-backend-file-migrate-bdb.h | 43 + addressbook/backends/file/e-book-backend-file.c | 1428 ++++---------------- 4 files changed, 866 insertions(+), 1135 deletions(-) commit 4a9dc35fa6ea5d4adcc7acfb3cf1b2e2263a5905 Author: Tristan Van Berkom Date: Mon Oct 29 14:40:47 2012 +0900 EBookBackendSqliteDB: Added e_book_backend_sqlitedb_get/set_revision() In preperation for the migration, there needs to be a way to persist the overall addressbook revision. This patch also increments the internal SQLite DB format version and adds the new revision column to for main folders table of an addressbook (and increments the stored DB version) if the DB version is out of date. .../libedata-book/e-book-backend-sqlitedb.c | 221 ++++++++++++++++++-- .../libedata-book/e-book-backend-sqlitedb.h | 11 + 2 files changed, 209 insertions(+), 23 deletions(-) commit 329181ac5931bace95bd4cba8c75187d63df61e8 Author: Tristan Van Berkom Date: Mon Oct 29 14:34:55 2012 +0900 EBookBackendSqliteDB: Fixed sexp interpretation for 'id' field. In the sqlite backend, the 'id' is stored as the 'uid' column. addressbook/libedata-book/e-book-backend-sqlitedb.c | 2 ++ 1 file changed, 2 insertions(+) commit 128cad02f044cb96e830deb08659075dca1c7fc5 Author: Matthew Barnes Date: Wed Nov 7 08:31:52 2012 -0500 Revert "calendar: Drop old ECalSourceTypeEnum from introspected API" This reverts commit 3183733023f022a89980cbf3f7292bde0bbd9954. We no longer introspect deprecated API. Remove the cruft. calendar/libecal/e-cal.h | 2 -- 1 file changed, 2 deletions(-) commit fab2ee606fad729edafc9a22379a26c01b1f0eb5 Author: Matthew Barnes Date: Wed Nov 7 07:53:56 2012 -0500 Disable runtime check in source_registry_initable_init(). Rationale explained in the source code. libedataserver/e-source-registry.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) commit ffd4d6931fd5af8624610825dd026139a6926a38 Author: Dan Williams Date: Wed Nov 7 06:59:51 2012 -0500 Bug 687694 - imapx_untagged_vanished() is inefficient For uid->len = 318320, timing the loop yields: g_list_append(): 60+ seconds g_list_prepend(): 0.3 seconds camel/camel-imapx-server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f423c3f6b52212e4f99c64fa27c4d2be88c85f2a Author: Milan Crha Date: Wed Nov 7 13:08:51 2012 +0100 Bug #687642 - Crash under caldav_synch_slave_loop() calendar/backends/caldav/e-cal-backend-caldav.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 56e8972729214df0de90a32b39bc0ce3d13cfa95 Author: Andreas Kohn Date: Wed Nov 7 12:32:28 2012 +0100 Bug #669082 - Workaround crash in imapx_command_copy_messages_step_done() camel/camel-imapx-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f7da59992f82768c798acd53ce180da286726a55 Author: Giovanni Campagna Date: Sun Oct 28 16:24:46 2012 +0100 Google: allow writing X-GOOGLE-SYSTEM-GROUP-IDS We expose GData system groups as an extended attribute with that name, but if we found it in the EContact we would turn it into an extended property. Instead, marshal the system group IDs into Evolution categories, and then those into GData groups or system groups. https://bugzilla.gnome.org/show_bug.cgi?id=687051 addressbook/backends/google/e-book-google-utils.c | 37 +++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) commit 5099a4755d6821a10ed223428f790c0eb5b89303 Author: Milan Crha Date: Tue Nov 6 18:58:12 2012 +0100 Bug #687776 - E-D-S crash in local address book addressbook/backends/file/e-book-backend-file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 1f2e9d445367e30947e012cf5508e50c4ca1e27e Author: Milan Crha Date: Tue Nov 6 11:07:07 2012 +0100 Introduce --enable-strict configure option This is currently used to add extra AM_CPPFLAGS to disable deprecated symbols from GLib. configure.ac | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) commit 7bcf1a51c70330a1549f9d712af4be9894d7b103 Author: Kjartan Maraas Date: Mon Nov 5 21:06:43 2012 +0100 Updated Norwegian bokmål translation po/nb.po | 1406 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 723 insertions(+), 683 deletions(-) commit aaf1f2cb931f00baaa9174ab3431b1783186797c Author: Milan Crha Date: Mon Nov 5 20:51:41 2012 +0100 Use soup_message_headers_get_list() as a replacement of soup_message_headers_get() CalDAV backend didn't receive proper value for access right, which caused reject of the login to the server. addressbook/backends/webdav/e-book-backend-webdav.c | 6 +++--- calendar/backends/caldav/e-cal-backend-caldav.c | 14 +++++++------- calendar/backends/http/e-cal-backend-http.c | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) commit 6ab88a4991d51cf7a46e2fb7ce9b2278973ef7c5 Author: Milan Crha Date: Mon Nov 5 20:39:59 2012 +0100 Replace deprecated soup_message_headers_get() addressbook/backends/webdav/e-book-backend-webdav.c | 6 +++--- calendar/backends/caldav/e-cal-backend-caldav.c | 14 +++++++------- calendar/backends/http/e-cal-backend-http.c | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) commit a22972f4bd76a15729e95a7b9cb75021ed2c38af Author: Milan Crha Date: Mon Nov 5 20:19:01 2012 +0100 Replace deprecated GLib symbols (as of GLib 2.34.x) addressbook/backends/file/e-book-backend-file.c | 8 +- .../backends/google/e-gdata-goa-authorizer.c | 14 +- addressbook/backends/ldap/e-book-backend-ldap.c | 412 ++++++++++---------- addressbook/backends/ldap/e-source-ldap.c | 26 +- addressbook/backends/vcf/e-book-backend-vcf.c | 40 +- addressbook/backends/vcf/e-source-vcf.c | 16 +- .../backends/webdav/e-book-backend-webdav.c | 5 +- addressbook/libebook/e-book-client.c | 6 +- .../libedata-book/e-book-backend-sqlitedb.c | 48 +-- addressbook/libedata-book/e-book-backend.c | 60 +-- addressbook/libedata-book/e-data-book-factory.c | 32 +- addressbook/libedata-book/e-data-book-view.c | 34 +- addressbook/libedata-book/e-data-book.c | 22 +- calendar/backends/caldav/e-cal-backend-caldav.c | 89 ++--- .../backends/contacts/e-cal-backend-contacts.c | 36 +- calendar/backends/file/e-cal-backend-file.c | 154 ++++---- calendar/backends/file/e-source-local.c | 14 +- calendar/backends/weather/e-source-weather.c | 16 +- calendar/libecal/e-cal-client.c | 26 +- calendar/libecal/e-cal-system-timezone.c | 8 +- calendar/libecal/e-cal.c | 10 +- calendar/libedata-cal/e-cal-backend-file-store.c | 74 ++-- calendar/libedata-cal/e-cal-backend-intervaltree.c | 20 +- calendar/libedata-cal/e-cal-backend-sync.c | 18 +- calendar/libedata-cal/e-cal-backend.c | 60 +-- calendar/libedata-cal/e-data-cal-factory.c | 32 +- calendar/libedata-cal/e-data-cal-view.c | 38 +- calendar/libedata-cal/e-data-cal.c | 22 +- camel/camel-block-file.c | 44 +-- camel/camel-certdb.c | 50 +-- camel/camel-cipher-context.c | 10 +- camel/camel-data-wrapper.c | 10 +- camel/camel-db.c | 70 ++-- camel/camel-debug.c | 18 +- camel/camel-folder-summary.c | 56 +-- camel/camel-folder.c | 20 +- camel/camel-imapx-command.c | 26 +- camel/camel-imapx-conn-manager.c | 44 +-- camel/camel-imapx-folder.c | 28 +- camel/camel-imapx-folder.h | 4 +- camel/camel-imapx-job.c | 26 +- camel/camel-imapx-server.c | 86 ++-- camel/camel-imapx-server.h | 6 +- camel/camel-imapx-settings.c | 26 +- camel/camel-imapx-store.c | 18 +- camel/camel-imapx-store.h | 2 +- camel/camel-local-settings.c | 16 +- camel/camel-lock-client.c | 6 +- camel/camel-mime-utils.c | 6 +- camel/camel-msgport.c | 12 +- camel/camel-msgport.h | 3 +- camel/camel-net-utils.c | 2 +- camel/camel-object-bag.c | 62 +-- camel/camel-operation.c | 6 +- camel/camel-partition-table.c | 20 +- camel/camel-provider.c | 6 +- camel/camel-sasl-popb4smtp.c | 6 +- camel/camel-service.c | 36 +- camel/camel-session.c | 26 +- camel/camel-store-summary.c | 30 +- camel/camel-store.c | 10 +- camel/camel-string-utils.c | 18 +- camel/camel-text-index.c | 10 +- camel/camel-transport.c | 10 +- camel/camel-vee-data-cache.c | 74 ++-- camel/camel-vee-folder.c | 30 +- camel/camel-vee-store.c | 38 +- camel/providers/imap/camel-imap-command.c | 18 +- camel/providers/imap/camel-imap-folder.c | 8 +- camel/providers/imap/camel-imap-private.h | 18 +- camel/providers/imap/camel-imap-settings.c | 56 +-- camel/providers/imap/camel-imap-store.c | 4 +- camel/providers/imap/camel-imap-store.h | 2 +- camel/providers/imap/camel-imap-wrapper.c | 10 +- camel/providers/local/camel-local-folder.c | 4 +- camel/providers/local/camel-local-private.h | 6 +- camel/providers/local/camel-maildir-summary.c | 12 +- camel/providers/nntp/camel-nntp-folder.c | 8 +- camel/providers/nntp/camel-nntp-private.h | 13 +- camel/providers/sendmail/camel-sendmail-settings.c | 26 +- camel/tests/folder/test10.c | 6 +- camel/tests/folder/test8.c | 6 +- camel/tests/lib/camel-test.c | 6 +- configure.ac | 10 +- libebackend/e-authentication-mediator.c | 70 ++-- libebackend/e-authentication-session.c | 36 +- libebackend/e-collection-backend.c | 44 +-- libebackend/e-data-factory.c | 10 +- libebackend/e-source-registry-server.c | 70 ++-- libebackend/e-sqlite3-vfs.c | 28 +- libedataserver/e-categories.c | 2 +- libedataserver/e-client.c | 66 ++-- libedataserver/e-data-server-util.c | 2 +- libedataserver/e-debug-log.c | 6 +- libedataserver/e-flag.c | 60 ++- libedataserver/e-flag.h | 4 +- libedataserver/e-operation-pool.c | 16 +- libedataserver/e-source-alarms.c | 16 +- libedataserver/e-source-authentication.c | 36 +- libedataserver/e-source-backend.c | 16 +- libedataserver/e-source-collection.c | 16 +- libedataserver/e-source-goa.c | 16 +- libedataserver/e-source-mail-account.c | 16 +- libedataserver/e-source-mail-composition.c | 46 +-- libedataserver/e-source-mail-identity.c | 56 +-- libedataserver/e-source-mail-signature.c | 16 +- libedataserver/e-source-mail-submission.c | 26 +- libedataserver/e-source-openpgp.c | 26 +- libedataserver/e-source-refresh.c | 22 +- libedataserver/e-source-registry.c | 80 ++-- libedataserver/e-source-resource.c | 16 +- libedataserver/e-source-security.c | 16 +- libedataserver/e-source-selectable.c | 16 +- libedataserver/e-source-smime.c | 36 +- libedataserver/e-source-webdav.c | 62 +-- libedataserver/e-source.c | 74 ++-- tests/libebook/client/client-test-utils.c | 10 +- tests/libecal/client/client-test-utils.c | 10 +- 118 files changed, 1778 insertions(+), 1788 deletions(-) commit 8b70b40c013c4a51236647ba4b4c64e7afafbbcf Author: Paul Menzel Date: Sun Nov 4 22:43:32 2012 +0100 [l10n] Fixed German translation, bug #687562 po/de.po | 104 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 53 insertions(+), 51 deletions(-) commit 1bfd6765d4684ab91842aabb87604badf80b52c0 Author: Matthew Barnes Date: Sun Nov 4 11:41:16 2012 -0500 EBookBackendSqliteDB: Add argument guards. .../libedata-book/e-book-backend-sqlitedb.c | 105 ++++++++++++++++++-- 1 file changed, 98 insertions(+), 7 deletions(-) commit 05985295169e912ed3453f7421a6ddc46fb4d8ac Author: Yuri Myasoedov Date: Sun Nov 4 20:21:41 2012 +0400 Updated Russian translation po/ru.po | 133 +++++++++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 89 insertions(+), 44 deletions(-) commit acd4422a58907ee7f0eed5057d58e37253f7532e Author: Matthew Barnes Date: Fri Nov 2 18:01:35 2012 -0400 vala: Remove unused metadata. vala/EBook-1.2.metadata | 3 --- vala/ECalendar-1.2.metadata | 1 - vala/EDataServer-1.2.metadata | 1 - 3 files changed, 5 deletions(-) commit dfcbcc22283232f308a78c4726f36a67eb5210ab Author: Matthew Barnes Date: Fri Nov 2 17:49:13 2012 -0400 Exclude deprecated API from introspection. Deprecated APIs were deprecated for a reason. The last thing we should be doing is enabling their continued use in other languages. Henceforth, any symbols tagged with EDS_DISABLED_DEPRECATED will be automatically excluded from introspection and language bindings. addressbook/libebook/Makefile.am | 1 + calendar/libecal/Makefile.am | 1 + libedataserver/Makefile.am | 1 + 3 files changed, 3 insertions(+) commit 8b1bac15b7eb6cd7b6b9896ebde6f7aa53297649 Author: Matthew Barnes Date: Fri Nov 2 17:47:38 2012 -0400 Introspection cleanups. addressbook/libebook/Makefile.am | 58 +++++++++++++++++++++++--------------- calendar/libecal/Makefile.am | 26 +++++++++++++---- libedataserver/Makefile.am | 21 +++++++++++--- 3 files changed, 73 insertions(+), 32 deletions(-) commit 2b8c8e8a8a49f341a9116da86e68fbc182fd1c1d Author: Matthew Barnes Date: Fri Nov 2 16:57:39 2012 -0400 Remove E_BOOK_DISABLE_DEPRECATED and E_CAL_DISABLE_DEPRECATED. We already use EDS_DISABLE_DEPRECATED, these other definitions only confuse matters. addressbook/libebook/e-book-types.h | 2 +- addressbook/libebook/e-book-view-private.h | 4 +- addressbook/libebook/e-book-view.h | 4 +- addressbook/libebook/e-book.h | 39 ++------------------ addressbook/libebook/e-destination.h | 9 ++--- calendar/libecal/e-cal-check-timezones.h | 4 +- calendar/libecal/e-cal-types.h | 7 ++-- calendar/libecal/e-cal-view-private.h | 4 +- calendar/libecal/e-cal-view.h | 4 +- calendar/libecal/e-cal.h | 11 +++--- calendar/libedata-cal/e-data-cal-view.h | 4 +- configure.ac | 24 ------------ docs/reference/addressbook/libebook/Makefile.am | 2 +- .../addressbook/libedata-book/Makefile.am | 2 +- docs/reference/calendar/libecal/Makefile.am | 2 +- docs/reference/calendar/libedata-cal/Makefile.am | 2 +- libedataserverui/e-book-auth-util.h | 8 ++-- tests/libebook/Makefile.am | 29 +-------------- tests/libecal/Makefile.am | 4 -- 19 files changed, 39 insertions(+), 126 deletions(-) commit e8ecbd7356caf9e3a4668a71224c60cce2bf94bf Author: Matthew Barnes Date: Fri Nov 2 16:33:03 2012 -0400 Suppress g-ir-scanner warnings. They're far too noisy, and make it difficult to spot new C compiler warnings, which are the only ones I care about. We can enable them again when we're serious about cleaning them up. In the meantime, they're just getting in the way. addressbook/libebook/Makefile.am | 2 +- calendar/libecal/Makefile.am | 2 +- libedataserver/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 3183733023f022a89980cbf3f7292bde0bbd9954 Author: Colin Walters Date: Fri Nov 2 14:29:13 2012 -0400 calendar: Drop old ECalSourceTypeEnum from introspected API It clashes when generating the vala bindings, and we're just keeping it around for C API consumers. calendar/libecal/e-cal.h | 2 ++ vala/ECalendar-1.2.metadata | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) commit 362947bc55a7f1bafdf49129af0c142df12455b2 Author: Matthew Barnes Date: Fri Nov 2 13:43:38 2012 -0400 e-cal-view.c: Remove unnecessary #includes. calendar/libecal/e-cal-view.c | 1 - 1 file changed, 1 deletion(-) commit 499acb9466ab33387fbeb66315f63f96cf86667f Author: Matthew Barnes Date: Fri Nov 2 13:43:22 2012 -0400 e-cal.c: Remove unnecessary #includes. calendar/libecal/e-cal.c | 4 ---- 1 file changed, 4 deletions(-) commit c1223be57fd3be4d228e1aba39bc7e6fe1b460d6 Author: Matthew Barnes Date: Fri Nov 2 13:42:57 2012 -0400 e-book-view.c: Remove unnecessary #includes. addressbook/libebook/e-book-view.c | 1 - 1 file changed, 1 deletion(-) commit 7c46fb6d0a54efb38ab0f824bea7532e11cf4e1c Author: Matthew Barnes Date: Fri Nov 2 13:41:49 2012 -0400 e-book.c: Remove unnecessary #includes. addressbook/libebook/e-book.c | 4 ---- 1 file changed, 4 deletions(-) commit c138ed493376f1e5bd35f1bfd688f7eb5863d022 Author: Matthew Barnes Date: Fri Nov 2 13:28:05 2012 -0400 Update libedataserverui API documentation. .../libedataserverui/libedataserverui-sections.txt | 2 + libedataserverui/e-name-selector-dialog.c | 49 ++++++++++---------- libedataserverui/e-name-selector-dialog.h | 6 +-- 3 files changed, 30 insertions(+), 27 deletions(-) commit 9165bb977ef0c38bbe008b0b920815ca9e0da4a2 Author: Matthew Barnes Date: Fri Nov 2 13:15:00 2012 -0400 Fix invalid Gtk-Doc syntax in comments. Not certain this is everything, just what I could find. addressbook/libedata-book/e-data-book-view.c | 7 ++++--- calendar/libecal/e-cal-check-timezones.c | 2 +- calendar/libecal/e-cal-client.c | 22 +++++++++++----------- calendar/libecal/e-cal-component.c | 7 ++++--- calendar/libecal/e-cal.c | 22 +++++++++++----------- 5 files changed, 31 insertions(+), 29 deletions(-) commit ab14a0a4aa89ecb141b854b754be3b65a1db1041 Author: Matthew Barnes Date: Fri Nov 2 09:12:38 2012 -0400 Reimplement ECal using ECalClient. This is primarily so I don't have to duplicate work while overhauling the D-Bus API, but it's good to do anyway; it simplifies the deprecated logic and helps ensure the two APIs behave consistently. calendar/libecal/e-cal.c | 2713 +++++++++------------------------------------- 1 file changed, 489 insertions(+), 2224 deletions(-) commit 6c23329cb94192651b81d2b64fc702052359eba9 Author: Matthew Barnes Date: Fri Nov 2 07:41:22 2012 -0400 Reimplement ECalView using ECalClientView. This is primarily so I don't have to duplicate work while overhauling the D-Bus API, but it's good to do anyway; it simplifies the deprecated logic and helps ensure the two APIs behave consistently. calendar/libecal/e-cal-view-private.h | 17 +- calendar/libecal/e-cal-view.c | 406 ++++++++++++--------------------- calendar/libecal/e-cal-view.h | 18 +- 3 files changed, 160 insertions(+), 281 deletions(-) commit e2f07bd319bf9d653716b0d56bfdc5581d0391d1 Author: Matthew Barnes Date: Mon Oct 29 17:44:32 2012 -0400 Reimplement EBook using EBookClient. This is primarily so I don't have to duplicate work while overhauling the D-Bus API, but it's good to do anyway: it simplifies the deprecated logic and helps ensure the two APIs behave consistently. addressbook/libebook/e-book.c | 1888 +++++++++++++++-------------------------- 1 file changed, 699 insertions(+), 1189 deletions(-) commit 37bda5047b710366d40f97156836aa0508755627 Author: Matthew Barnes Date: Mon Oct 29 20:24:14 2012 -0400 Reimplement EBookView using EBookClientView. This is primarily so I don't have to duplicate work while overhauling the D-Bus API, but it's good to do anyway: it simplifies the deprecated logic and helps ensure the two APIs behave consistently. addressbook/libebook/e-book-view-private.h | 18 +- addressbook/libebook/e-book-view.c | 424 ++++++++++++++-------------- 2 files changed, 223 insertions(+), 219 deletions(-) commit ef57ec14f56f11c861afcc8eeb3719263022864d Author: Matthew Barnes Date: Fri Nov 2 09:19:16 2012 -0400 e-cal-view.h cleanups. calendar/libecal/e-cal-view.h | 69 ++++++++++++-------- .../calendar/libecal/libecal-sections.txt | 5 +- 2 files changed, 45 insertions(+), 29 deletions(-) commit 8c4934cd6984344144599ffba1708cfd10718756 Author: Matthew Barnes Date: Fri Nov 2 09:13:53 2012 -0400 e-book-view.h cleanups. addressbook/libebook/e-book-view.h | 92 ++++++++++++++++++++---------------- 1 file changed, 52 insertions(+), 40 deletions(-) commit cc9e64ba9d1a8aa6577d77c2c07eea85c14999ec Author: Milan Crha Date: Fri Nov 2 11:09:03 2012 +0100 e_async_closure_callback: Do not test 'object' parameter validity It is unnecessary to test validity of the 'object' parameter, especially when this callback does nothing with it. The reason is that the secret_password_store() calls the callback with NULL 'object', which leads to a deadlock on the source registry side. libedataserver/e-data-server-util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit c81d3a885bb3e2937a82e3cc12cfa23f89d65f71 Author: Milan Crha Date: Fri Nov 2 10:39:26 2012 +0100 Bug #685090 - GOA EWS module doesn't save all required values modules/gnome-online-accounts/goaewsclient.c | 41 +++++++++++++++- .../module-gnome-online-accounts.c | 49 +++++++++++++++++++- 2 files changed, 88 insertions(+), 2 deletions(-) commit e3143075d4de04795499b0ac66c5b3cd9b47f727 Author: Milan Crha Date: Fri Nov 2 09:28:55 2012 +0100 Collection's child source Enabled should match collections Enabled libebackend/e-collection-backend.c | 5 +++++ 1 file changed, 5 insertions(+) commit c4c1119e110980b5dffe6b7fb94020b39dc001ec Author: Milan Crha Date: Fri Nov 2 09:24:50 2012 +0100 Revert "Revert "Bug #678400 - ECollectionBackend populates disabled accounts"" This reverts commit 1c4fb39c131a03428035a2035fca8ea462fc7714, because the initial revert was a misunderstanding of the change. libebackend/e-collection-backend.c | 37 ++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) commit ef65cec8a261e8dbace68435da9740d1fd021557 Author: Matthew Barnes Date: Thu Nov 1 13:52:05 2012 -0400 Add AllowAuthPromptAll() method to SourceManager interface. Equivalent to calling AllowAuthPrompt() on each exported data source, but cuts way down on the D-Bus traffic. Since the registry service is commonly activated during a desktop session startup, this can actually clog up the session bus and slow down login. This leaves the source-specific AllowAuthPrompt() method unused, but there are still use cases for it which we haven't implemented yet, so leave it be. configure.ac | 2 +- .../private/libedbus-private-sections.txt | 4 +++ libebackend/e-source-registry-server.c | 26 ++++++++++++++++++++ libedataserver/e-source-registry.c | 8 ++++++ libedataserver/e-source.c | 15 ----------- ...rg.gnome.evolution.dataserver.SourceManager.xml | 9 +++++++ 6 files changed, 48 insertions(+), 16 deletions(-) commit d2b78d70140c3c9cbb7d64dcbd88213044c71b35 Author: Matthew Barnes Date: Thu Nov 1 09:38:49 2012 -0400 Remove version number from ${privincludedir}. Last man standing, so may as well. Version not needed there either. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5abba8fd5af4d03a24a2f04c42c6af044f6b5cab Author: Matthew Barnes Date: Thu Nov 1 09:35:00 2012 -0400 Remove erroneous version number from ${privlibdir}. This slipped through because we don't actually reference ${privlibdir} in our backend/module/provider directory definitions. Fix that too. Also, some pkg-config files needed to be tweaked as a result of this. addressbook/libedata-book/libedata-book.pc.in | 4 +++- calendar/libedata-cal/libedata-cal.pc.in | 4 +++- camel/camel.pc.in | 3 ++- configure.ac | 10 +++++----- libebackend/libebackend.pc.in | 2 ++ 5 files changed, 15 insertions(+), 8 deletions(-) commit 95bc74baded8784fc937a4096c542d49f19d6ce5 Author: Matthew Barnes Date: Thu Nov 1 07:35:39 2012 -0400 Remove version number from ${privdatadir}. In talking to some people at Red Hat about how to deploy pre-configured Evolution accounts, one thing I suggested is to provide a package which installs .source files to one of the system-wide locations: /usr/share/evolution-data-server-3.8/ro-sources /usr/share/evolution-data-server-3.8/rw-sources But that's not going to work in general with the version number in the path. Upgrading E-D-S to, say, 3.10 would invalidate such a package. Remove the version number from our ${privdatadir}. It's not needed. configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 0e4713735bb0c51f6fc4808834eb15de25fd5269 Author: Milan Crha Date: Tue Oct 30 18:59:40 2012 +0100 Bug #681962 - Identify server certificates by hostname and fingerprint camel/camel-certdb.c | 102 ++++++++++++++++++++++++++++++++++++------ camel/camel-certdb.h | 4 +- camel/camel-tcp-stream-ssl.c | 11 ++--- 3 files changed, 94 insertions(+), 23 deletions(-) commit db335259356491165b2ecf3debf7a2b4a58e87ff Author: Milan Crha Date: Tue Oct 30 18:48:30 2012 +0100 Bug #685034 - [imapx] Read status of email is not persisted correctly camel/camel-imapx-server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 011b0aff98188ab407f76e72c58c12ecba970838 Author: Milan Crha Date: Mon Oct 29 17:05:22 2012 +0100 Bug #687100 - Crash under cal_backend_contacts_remove_book_record() calendar/backends/contacts/e-cal-backend-contacts.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 2c938b61c884bf2e507e2f32ea8489fa3d235b48 Author: Milan Crha Date: Mon Oct 29 15:12:02 2012 +0100 Bug #686924 - Doesn't parse Gerrit encoded From address correctly camel/camel-mime-utils.c | 48 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-) commit 3ea35694702692ad17895e5751146127606e591d Author: Matthew Barnes Date: Sun Oct 28 07:38:10 2012 -0400 imapx_command_start: Improve handling of write-to-stream error. For some reason we were calling camel_stream_write_string() without passing a GError, and on failure setting a very generic error message and losing potentially useful information about the actual error. camel/camel-imapx-server.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) commit 455f368e58088f968d13e24441a6963d6c0f9fbe Author: Matthew Barnes Date: Sat Oct 27 12:27:04 2012 -0400 Use code coverage macros from gnome-common. The GNOME_CODE_COVERAGE macro in gnome-common automates the process nicely. Just run "make check-code-coverage" from the top-level source directory (or from any of the "tests" subdirectories) and open the nice coverage analysis report: evolution-data-server-x.y.z-coverage/index.html Makefile.am | 2 + configure.ac | 22 ++------ tests/Makefile.am | 2 + tests/libebook/Makefile.am | 2 + tests/libecal/Makefile.am | 2 + tests/libedata-cal/Makefile.am | 114 ++++++++++++++------------------------ tests/libedataserver/Makefile.am | 2 + 7 files changed, 57 insertions(+), 89 deletions(-) commit 6f98b459bd9abd55dbdee995e4bdb15da3797023 Author: Matthew Barnes Date: Fri Oct 26 22:45:59 2012 -0400 Bug 685986 - ESourceRegistry: Wait for signals after creating sources e_source_registry_create_sources_sync() now waits for "object-added" signals from its GDBusObjectManagerClient before returning. This allows the newly-created ESources to be obtained immediately after the function returns. Prior to this there was a small delay before the newly-created ESources became available through the ESourceRegistry API. There is a caveat to this. If any of the scratch ESources reference a parent UID which is not presently exported by the registry service, the registry service will refuse to export the newly-created ESource until its parent becomes available. In this scenario, to avoid waiting forever for an "object-added" signal that isn't coming, we place a limit on the wait time (two seconds). If this time limit expires, we return from the function regardless. libedataserver/e-source-registry.c | 159 ++++++++++++++++++++++++++++++++---- 1 file changed, 141 insertions(+), 18 deletions(-) commit d62d6eef737b30510ab10993b9e78f440b542477 Author: Matthew Barnes Date: Fri Oct 26 16:34:10 2012 -0400 Add a test case for bug 685986. Managed to reproduce the bug using the test case. tests/libedataserver/Makefile.am | 47 ++++++-- tests/libedataserver/e-source-registry-test.c | 152 +++++++++++++++++++++++++ 2 files changed, 187 insertions(+), 12 deletions(-) commit bb30f5774058af0fbcf8a969d61cf83d819b6df1 Author: Matthew Barnes Date: Fri Oct 26 16:30:20 2012 -0400 Prototype a D-Bus unit test harness. Add functions for programmatically overriding XDG base directories and launching a private D-Bus session bus using GTestDBus. This requires Evolution-Data-Server to be installed, since the test harness references D-Bus service files by the installation prefix. tests/libedataserver/e-test-dbus-utils.c | 175 ++++++++++++++++++++++++++++++ tests/libedataserver/e-test-dbus-utils.h | 34 ++++++ 2 files changed, 209 insertions(+) commit 801ab892dd57610ffe65ede4739664029b466650 Author: Matthew Barnes Date: Fri Oct 26 16:27:36 2012 -0400 Bump minimum GLib requirement to 2.34. Need to utilize the GTestDBus API, which is new in 2.34. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 00726df32a78cea08fb3998e17104c5efdd9ad05 Author: Andika Triwidada Date: Sat Oct 27 15:33:20 2012 +0700 Updated Indonesian translation po/id.po | 749 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 385 insertions(+), 364 deletions(-) commit 52f87cba60b4d65a3d91718c25afc66d34db7db5 Author: JB Lallement Date: Fri Oct 26 11:26:13 2012 -0400 Bug 686719 - Missing linker flags in Camel tests camel/tests/folder/Makefile.am | 3 ++- camel/tests/message/Makefile.am | 3 ++- camel/tests/mime-filter/Makefile.am | 3 ++- camel/tests/misc/Makefile.am | 3 ++- camel/tests/smime/Makefile.am | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) commit 788f951a17401e148726c3e6605ad8a3cd93510f Author: Matej Urbančič Date: Thu Oct 25 19:52:58 2012 +0200 Updated Slovenian translation po/sl.po | 748 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 376 insertions(+), 372 deletions(-) commit fd738f119636cdaacfb44bf7fa64e93008f31198 Author: Matthew Barnes Date: Thu Oct 25 10:59:59 2012 -0400 Prefer e_source_registry_check_enabled(). Prefer e_source_registry_check_enabled() over e_source_get_enabled() for most instances where we want to exclude disabled data sources. calendar/libedata-cal/e-cal-backend-util.c | 4 +-- libedataserver/e-source-registry.c | 2 +- libedataserverui/e-name-selector-entry.c | 37 +--------------------------- libedataserverui/e-name-selector.c | 37 +--------------------------- 4 files changed, 5 insertions(+), 75 deletions(-) commit 7e21729caf6dd4c2f3a92935c0e38d6d27b589f0 Author: Matthew Barnes Date: Thu Oct 25 10:38:43 2012 -0400 Add e_source_registry_check_enabled(). Checks the enabled state of a given #ESource and of its ancestors to determine if the #ESource should be displayed or acted on. This is somewhat similar to widget sensitivity in GTK+. cf. gtk_widget_get_sensitive() versus gtk_widget_is_sensitive() .../libedataserver/libedataserver-sections.txt | 1 + libedataserver/e-source-registry.c | 52 ++++++++++++++++++++ libedataserver/e-source-registry.h | 2 + libedataserver/e-source.c | 8 +++ 4 files changed, 63 insertions(+) commit 84f897ff80ac113807b4fdd344c4c3268b6a4df0 Author: Milan Crha Date: Thu Oct 25 12:02:13 2012 +0200 Bug #680497 - POP3 re-adds messages to local Inbox camel/providers/pop3/camel-pop3-engine.c | 58 +++++++++++++++++--------- camel/providers/pop3/camel-pop3-engine.h | 10 +++-- camel/providers/pop3/camel-pop3-folder.c | 66 ++++++++++++++++++++++-------- camel/providers/pop3/camel-pop3-store.c | 22 ++++++---- 4 files changed, 110 insertions(+), 46 deletions(-) commit ff1949841d60850409093a666f819e5c963e81ba Author: Matthew Barnes Date: Wed Oct 24 17:28:25 2012 -0400 IMAPX: Explicitly pass GCancellable and GError to callbacks. Further error handling improvements. This involves some public API changes, but the impact is limited to evolution-kolab. * CamelIMAPXCommandFunc now takes a GCancellable argument in addition to its GError argument. * The public GCancellable member of CamelIMAPXJob is now private, and the public GError member is removed. * The start() method of CamelIMAPXJob now takes a GCancellable and GError argument. The GCancellable pass through this method call is always the CamelIMAPXJob's own private GCancellable. * A new camel_imapx_job_cancel() function which simply cancels the CamelIMAPXJob's internal GCancellable. Additional changes internal to CamelIMAPXServer are: * Adapt operations to the new callback function signatures. * imapx_command_queue() now takes a GCancellable and GError argument and returns a 'success' boolean. Other core job and command routing functions also now have similar function signatures. * Add error handling where needed, so that no failable function call goes unchecked. camel/camel-imapx-command.h | 1 + camel/camel-imapx-job.c | 58 ++-- camel/camel-imapx-job.h | 10 +- camel/camel-imapx-server.c | 536 ++++++++++++++++++------------- docs/reference/camel/camel-sections.txt | 1 + 5 files changed, 353 insertions(+), 253 deletions(-) commit 3594576b5710f46d4ac6e3b1c014cc343943182c Author: Milan Crha Date: Wed Oct 24 18:37:12 2012 +0200 Bug #686727 - POP3 provider deadlocks on finalize camel/providers/pop3/camel-pop3-store.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 3fe344727775fd70db7ace94e1dda62b3d83bf9e Author: Hendrik Knackstedt Date: Wed Oct 24 10:52:11 2012 +0200 Updated German translation po/de.po | 1000 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 523 insertions(+), 477 deletions(-) commit b46171b645a7e120fc25d627d84f07bea964d17c Author: Matthew Barnes Date: Tue Oct 23 16:07:47 2012 -0400 CamelIMAPXServer: Handle errors in imapx_continuation(). There was no error handling at all on the write-to-stream operations. camel/camel-imapx-server.c | 58 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 48 insertions(+), 10 deletions(-) commit 687ac881cf58df2e01dc509c007321f758b0c9d2 Author: Matthew Barnes Date: Tue Oct 23 15:31:56 2012 -0400 CamelIMAPXServer: Return a boolean from imapx_command_start_next(). The function is failable and takes a GError, yet returns void. This is how GErrors pile up. Return a boolean and add the necessary error checks where the function is called. camel/camel-imapx-server.c | 73 ++++++++++++++++++++++++++++++++------------ 1 file changed, 54 insertions(+), 19 deletions(-) commit 1c4fb39c131a03428035a2035fca8ea462fc7714 Author: Matthew Barnes Date: Tue Oct 23 14:32:06 2012 -0400 Revert "Bug #678400 - ECollectionBackend populates disabled accounts" This reverts commit 9a7948409852e57721dcb2e9e63ae69d8ac78d40. Need to find a better solution than corrupting what are supposed to be separate state flags. libebackend/e-collection-backend.c | 37 ++++++------------------------------ 1 file changed, 6 insertions(+), 31 deletions(-) commit 9a7948409852e57721dcb2e9e63ae69d8ac78d40 Author: Milan Crha Date: Tue Oct 23 20:15:09 2012 +0200 Bug #678400 - ECollectionBackend populates disabled accounts libebackend/e-collection-backend.c | 37 ++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) commit 21a5722a814e91e7224978e26ce86c751f6fe017 Author: Matthew Barnes Date: Tue Oct 23 12:07:50 2012 -0400 CamelIMAPXServer: Improve error handling around stopping IDLE. imapx_stop_idle() returned a boolean but TRUE had an ambiguous interpretation. It either meant the DONE command was sent or an I/O error occurred. Define a new enum type (CamelIMAPXIdleStopResult) to resolve the ambiguity. Also imapx_command_idle_stop() returned a boolean but FALSE had an ambiguous interpretation. It either meant an I/O error occurred, or there was no available CamelIMAPXStream from which to issue the DONE command. Resolve the ambiguity by forcing callers to explicitly pass in a CamelIMAPXStream (and a GCancellable, while we're at it). camel/camel-imapx-server.c | 152 +++++++++++++++++++++++++++++--------------- 1 file changed, 100 insertions(+), 52 deletions(-) commit 8a77efaa3f94ec1a6aa4743c72e1a0b34163e8b8 Author: Matthew Barnes Date: Tue Oct 23 11:04:21 2012 -0400 CamelIMAPXServer: Declare imapx_uidset_* functions as static. These functions were never meant to be exported. The "static" keyword seems to have been omitted by accident. Can't find any evidence of them being called from outside camel-imapx-server.c, so just make them static. camel/camel-imapx-server.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit bc4f85db1f4efabe6c991fdccec00209a5b8c863 Author: Matthew Barnes Date: Tue Oct 23 10:53:46 2012 -0400 CamelIMAPXServer: Clean up static function declarations. One argument per line. camel/camel-imapx-server.c | 59 +++++++++++++++++++++++++++++++------------- 1 file changed, 42 insertions(+), 17 deletions(-) commit 0fa4740592cf6aa06a552e4b8af724083e35f404 Author: Matthew Barnes Date: Tue Oct 23 10:57:07 2012 -0400 CamelIMAPXServer: Make sure all disabled bits have a comment. Normally I throw away all disabled-with-no-explanation-why code chunks, but in this case they all seem related, so clarify that in the code. camel/camel-imapx-server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 05285730906386ff805fa61e9f47048e6db30490 Author: Gabor Kelemen Date: Tue Oct 23 14:50:01 2012 +0200 Updated Hungarian translation po/hu.po | 1349 ++++++++++++++++++++++++++------------------------------------ 1 file changed, 561 insertions(+), 788 deletions(-) commit d4e32002bfae7e48a83da10dfe53d17efafb74c6 Author: Matthew Barnes Date: Mon Oct 22 13:20:11 2012 -0400 EAuthenticationSession: Close prompt before storing password. Close our prompt before storing the password in the keyring. If the keyring is locked, it will need to prompt the user for a keyring password, but it can't do that if our password prompt is still open since both prompts are system-modal. Not sure what would happen next; probably the store operation would either fail or deadlock. libebackend/e-authentication-session.c | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) commit 28d8a9473fd1066f9660e589fe5d10c9b39291ce Author: Milan Crha Date: Mon Oct 22 11:24:09 2012 +0200 Bug #640594 - Save also UID/REV in WebDAV backend (for CardDAV) addressbook/backends/webdav/e-book-backend-webdav.c | 4 ---- 1 file changed, 4 deletions(-) commit 6f8d8888f54be07f8e69639537ed3b8acbd7388e Author: Matthew Barnes Date: Sat Oct 20 20:53:15 2012 -0400 Post-release version bump. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)